Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-3626: Remove fb auth #961

Merged
merged 3 commits into from
Mar 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ dependencies {
implementation libraries.appCompat
implementation libraries.ktx
implementation libraries.recyclerview
implementation libraries.swiperefreshlayout
implementation libraries.viewPager
implementation libraries.viewPager2
implementation libraries.cardView
Expand Down Expand Up @@ -216,7 +217,7 @@ dependencies {
implementation libraries.firebaseConfig
implementation libraries.firebasePerf

implementation libraries.facebookSdk
// implementation libraries.facebookSdk
implementation libraries.vkSdk

implementation libraries.timber
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.stepik.android.domain.debug.interactor

import com.facebook.login.LoginManager
import com.google.firebase.messaging.FirebaseMessaging
import com.vk.api.sdk.VK
import io.reactivex.Completable
Expand Down Expand Up @@ -33,7 +32,7 @@ constructor(
sharedPreferenceHelper.putEndpointConfig(endpointConfig.ordinal)
}.andThen(
logoutManager.logoutCompletable {
LoginManager.getInstance().logOut()
// LoginManager.getInstance().logOut()
VK.logout()
}
)
Expand Down
4 changes: 1 addition & 3 deletions app/src/main/java/org/stepic/droid/base/App.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import android.webkit.WebView
import androidx.appcompat.app.AppCompatDelegate
import androidx.multidex.MultiDexApplication
import com.android.billingclient.api.BillingClient
import com.facebook.appevents.AppEventsLogger
import com.google.android.gms.security.ProviderInstaller
import com.squareup.leakcanary.LeakCanary
import com.squareup.leakcanary.RefWatcher
import com.vk.api.sdk.VK
Expand Down Expand Up @@ -109,7 +107,7 @@ class App : MultiDexApplication() {
WebView.setWebContentsDebuggingEnabled(true)
}

AppEventsLogger.activateApp(this)
// AppEventsLogger.activateApp(this)
VK.initialize(this)

// init AppMetrica SDK
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class SocialAuthAdapter extends RecyclerView.Adapter<SocialAuthAdapter.So
private State state;

public enum State {
EXPANDED(1), NORMAL(2);
EXPANDED(4), NORMAL(3);

public final int multiplier;
State(int multiplier) {
Expand Down Expand Up @@ -56,7 +56,7 @@ public void onBindViewHolder(SocialViewHolder holder, int position) {

@Override
public int getItemCount() {
return socialList.length / state.multiplier + (socialList.length % state.multiplier == 0 ? 0 : 1);
return state.multiplier;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.stepik.android.remote.auth.interceptor

import android.content.Context
import com.facebook.login.LoginManager
import com.vk.api.sdk.VK
import okhttp3.Interceptor
import okhttp3.Response
Expand Down Expand Up @@ -113,7 +112,7 @@ constructor(
extendedMessage = "failed ${oAuthResponse.code()} ${oAuthResponse.errorBody()?.string()}"
if (oAuthResponse.code() == 401) {
stepikLogoutManager.logout {
LoginManager.getInstance().logOut()
// LoginManager.getInstance().logOut()
VK.logout()
screenManager.showLaunchScreen(context)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ enum class SocialNetwork(
) : SocialAuthType {
GOOGLE("google", R.drawable.ic_login_social_google),
VK("vk", R.drawable.ic_login_social_vk, isNeedUseAccessTokenInsteadOfCode = true),
FACEBOOK("facebook", R.drawable.ic_login_social_fb, isNeedUseAccessTokenInsteadOfCode = true),
// FACEBOOK("facebook", R.drawable.ic_login_social_fb, isNeedUseAccessTokenInsteadOfCode = true),
TWITTER("twitter", R.drawable.ic_login_social_twitter),
GITHUB("github", R.drawable.ic_login_social_github)
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ import androidx.core.view.isVisible
import androidx.fragment.app.DialogFragment
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.GridLayoutManager
import com.facebook.CallbackManager
import com.facebook.FacebookCallback
import com.facebook.FacebookException
import com.facebook.login.LoginManager
import com.facebook.login.LoginResult
import com.google.android.gms.auth.api.Auth
import com.google.android.gms.common.api.GoogleApiClient
import com.vk.api.sdk.VK
Expand Down Expand Up @@ -90,7 +85,7 @@ class SocialAuthActivity : SmartLockActivityBase(), SocialAuthView {
private val progressDialogFragment: DialogFragment =
LoadingProgressDialogFragment.newInstance()

private lateinit var callbackManager: CallbackManager
// private lateinit var callbackManager: CallbackManager

private var selectedSocialType: SocialNetwork? = null

Expand Down Expand Up @@ -144,20 +139,20 @@ class SocialAuthActivity : SmartLockActivityBase(), SocialAuthView {

signInText.text = spannableSignIn

callbackManager = CallbackManager.Factory.create()
LoginManager.getInstance().registerCallback(callbackManager, object : FacebookCallback<LoginResult> {
override fun onSuccess(loginResult: LoginResult) {
socialAuthPresenter
.authWithNativeCode(loginResult.accessToken.token, SocialNetwork.FACEBOOK)
}

override fun onCancel() {}

override fun onError(exception: FacebookException) {
analytic.reportError(Analytic.Login.FACEBOOK_ERROR, exception)
showNetworkError()
}
})
// callbackManager = CallbackManager.Factory.create()
// LoginManager.getInstance().registerCallback(callbackManager, object : FacebookCallback<LoginResult> {
// override fun onSuccess(loginResult: LoginResult) {
// socialAuthPresenter
// .authWithNativeCode(loginResult.accessToken.token, SocialNetwork.FACEBOOK)
// }
//
// override fun onCancel() {}
//
// override fun onError(exception: FacebookException) {
// analytic.reportError(Analytic.Login.FACEBOOK_ERROR, exception)
// showNetworkError()
// }
// })

if (checkPlayServices()) {
googleApiClient?.registerConnectionCallbacks(object : GoogleApiClient.ConnectionCallbacks {
Expand Down Expand Up @@ -238,8 +233,8 @@ class SocialAuthActivity : SmartLockActivityBase(), SocialAuthView {
}
}

SocialNetwork.FACEBOOK ->
LoginManager.getInstance().logInWithReadPermissions(this, listOf("email"))
// SocialNetwork.FACEBOOK ->
// LoginManager.getInstance().logInWithReadPermissions(this, listOf("email"))

SocialNetwork.VK ->
VK.login(this, listOf(VKScope.OFFLINE, VKScope.EMAIL))
Expand Down Expand Up @@ -314,7 +309,7 @@ class SocialAuthActivity : SmartLockActivityBase(), SocialAuthView {

super.onActivityResult(requestCode, resultCode, data)

callbackManager.onActivityResult(requestCode, resultCode, data)
// callbackManager.onActivityResult(requestCode, resultCode, data)

if (requestCode == REQUEST_CODE_GOOGLE_SIGN_IN && resultCode == Activity.RESULT_OK) {
val result = Auth.GoogleSignInApi.getSignInResultFromIntent(data)
Expand Down Expand Up @@ -360,7 +355,7 @@ class SocialAuthActivity : SmartLockActivityBase(), SocialAuthView {
Auth.GoogleSignInApi.signOut(googleApiClient)
}
// fb:
LoginManager.getInstance().logOut()
// LoginManager.getInstance().logOut()
}

override fun showNetworkError() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import androidx.fragment.app.DialogFragment
import androidx.fragment.app.Fragment
import androidx.fragment.app.viewModels
import androidx.lifecycle.ViewModelProvider
import com.facebook.login.LoginManager
import com.vk.api.sdk.VK
import kotlinx.android.synthetic.main.fragment_settings.*
import org.stepic.droid.R
Expand Down Expand Up @@ -237,7 +236,7 @@ class SettingsFragment :
}

override fun onLogoutSuccess() {
LoginManager.getInstance().logOut()
// LoginManager.getInstance().logOut()
VK.logout()
(activity as? SignOutListener)?.onSignOut()
screenManager.showLaunchScreenAfterLogout(requireContext())
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.stepik.android.domain.debug.interactor

import com.facebook.login.LoginManager
import com.google.firebase.messaging.FirebaseMessaging
import com.vk.api.sdk.VK
import io.reactivex.Completable
Expand Down Expand Up @@ -33,7 +32,7 @@ constructor(
sharedPreferenceHelper.putEndpointConfig(endpointConfig.ordinal)
}.andThen(
logoutManager.logoutCompletable {
LoginManager.getInstance().logOut()
// LoginManager.getInstance().logOut()
VK.logout()
}
)
Expand Down
6 changes: 4 additions & 2 deletions dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ext.versions = [
appCompat : '1.1.0',
ktx : '1.3.0',
recyclerview : '1.0.0',
swiperefreshlayout : '1.1.0',
viewPager : '1.0.0',
viewPager2 : '1.0.0',
cardView : '1.0.0',
Expand Down Expand Up @@ -72,7 +73,7 @@ ext.versions = [

billing : '4.0.0',

facebook : '8.1.0',
// facebook : '8.1.0',
vk : '2.2.3',

timber : '4.7.1',
Expand Down Expand Up @@ -139,6 +140,7 @@ ext.libraries = [
appCompat : "androidx.appcompat:appcompat:$versions.appCompat",
ktx : "androidx.core:core-ktx:$versions.ktx",
recyclerview : "androidx.recyclerview:recyclerview:$versions.recyclerview",
swiperefreshlayout : "androidx.swiperefreshlayout:swiperefreshlayout:$versions.swiperefreshlayout",
viewPager : "androidx.viewpager:viewpager:$versions.viewPager",
viewPager2 : "androidx.viewpager2:viewpager2:$versions.viewPager2",
cardView : "androidx.cardview:cardview:$versions.cardView",
Expand Down Expand Up @@ -201,7 +203,7 @@ ext.libraries = [
billing : "com.android.billingclient:billing:$versions.billing",
billingKtx : "com.android.billingclient:billing-ktx:$versions.billing",

facebookSdk : "com.facebook.android:facebook-android-sdk:$versions.facebook",
// facebookSdk : "com.facebook.android:facebook-android-sdk:$versions.facebook",
vkSdk : "com.vk:androidsdk:$versions.vk",

timber : "com.jakewharton.timber:timber:$versions.timber",
Expand Down