-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rectangular FoV marking follow real projection #3290
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks for quick solution!
The fix is not changed translatable strings, so, we can accept it for release 23.2 - is it OK for all?
|
||
/* | ||
* NOTE: uncomment the code for display FOV value in top right corner of marker | ||
if (fovRatio>=0.25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-w shall this be permanently deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a "hidden feature" :) As far nobody asked for it before, so, this part may be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When changing to equatorial (telescope) mode, the box is now tilted. @alex-w is this what you wanted?
This is good question. Previous solution didn't follow the mount types, but the current solution is followed it ( |
I am less sure about that and would see using the current mode more intuitive. However, if you like it being always in Azimuthal mode, it's OK to merge. I only use the Ocular plugin's sensor frame. |
Fixes #3015
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: