Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rectangular FoV marking follow real projection #3290

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

10110111
Copy link
Contributor

Fixes #3015

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04
  • Graphics Card: Intel UHD Graphics 620

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for quick solution!

The fix is not changed translatable strings, so, we can accept it for release 23.2 - is it OK for all?


/*
* NOTE: uncomment the code for display FOV value in top right corner of marker
if (fovRatio>=0.25)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-w shall this be permanently deleted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a "hidden feature" :) As far nobody asked for it before, so, this part may be removed.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing to equatorial (telescope) mode, the box is now tilted. @alex-w is this what you wanted?

@alex-w
Copy link
Member

alex-w commented Jun 28, 2023

When changing to equatorial (telescope) mode, the box is now tilted. @alex-w is this what you wanted?

This is good question. Previous solution didn't follow the mount types, but the current solution is followed it (derotate parameter). I think now it's better.

@gzotti
Copy link
Member

gzotti commented Jun 28, 2023

I am less sure about that and would see using the current mode more intuitive. However, if you like it being always in Azimuthal mode, it's OK to merge. I only use the Ocular plugin's sensor frame.

@alex-w alex-w added this to the 23.2 milestone Jun 28, 2023
@alex-w alex-w merged commit 81fb26d into Stellarium:master Jun 28, 2023
12 checks passed
@10110111 10110111 deleted the fov-markings branch June 28, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

rectangular FOV wrong for other than very small angles
3 participants