Nebula markers vectorization #3172
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Nice! Yes, IMHO the dots in CL+Neb should be a bit contracted. And now that this would technically be possible, can you please try mixing "green" nebula color box with "yellow" cluster color dot circle? |
I can, but won't it look as if we have two nebulas of different kinds at the same spot? Or do you want to visually separate the nebulosity as a separate nebula? |
|
This is how the color-separated version looks. Maybe the circle doesn't have to be contracted in this case.
|
|
I like the bicolor version. However, I'd still make the circle smaller to keep some buffer around the dots. |
|
The bicolor version of C+N markers is acceptable, but IMHO the circle should be a bit small - does not touche the rectangle. |
|
Shouldn’t the circles also be vectorized? |
Why do you think they haven't been? Or do you want to also vectorize the fluffy points that make up the circles? |
Yes, I would expect that vectorized markers be fully vectorized. |
I don't find any use in this, only potential performance ramifications. |
|
There is of course a change in overall appearance. The old icons had soft edges which became more blurry by upscaling (mitigated by a few icon sizes), while the new line-based symbols are hard-edged, but the dots are still "fluffy". Maybe the dots should become hard-edged as well? I understand drawing blurred lines needs more GPU code. |
New version:
|
Not sure about this. Some users have multisampling disabled, and such circles will look ugly when aliased. |
|
All the comments seem to have been addressed now. |
The marker of open cluster with nebulosity now looks as an open cluster and a nebula, with correspondingly different colors.
10110111
force-pushed
the
nebula-markers-vectorization
branch
from
9a8fc7f
to
49869e3
Compare
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
This is a continuation of #3166, now vectorizing markers of open clusters: simple and with nebulosity.
The number of dots now depends on the size of the marker. The markers of open clusters with nebulosity might look not the best way when they are small. Do you think the points should be moved closer to the center? Or is the way it looks now OK?
Screenshots
Old
New