Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow texture decimation #3009

Merged
merged 11 commits into from
Jan 22, 2023
Merged

Allow texture decimation #3009

merged 11 commits into from
Jan 22, 2023

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Jan 21, 2023

Description

This is related to #2982. I want to make Stellarium again usable on a Raspberry Pi 3 which has significant problems with limited texture memory. This change allows to limit the texture size on loading the nebula catalog. It should be sufficient to show the "fuzzies" just with less resolution.

The changes were pretty involved, following the logic of the StelSkyImageTiles until finally loading the textures.
I failed to adapt the formulation for a template, Ruslan provided the solution.

Fixes #550 (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configurations:

  • Win11/Geforce M3070Ti.
  • Raspberry Pi 3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti gzotti added enhancement Improve existing functionality importance: medium A bit annoying, minor miscalculation, but no crash labels Jan 21, 2023
@gzotti gzotti added this to the 23.1 milestone Jan 21, 2023
@gzotti gzotti self-assigned this Jan 21, 2023
@github-actions
Copy link

github-actions bot commented Jan 21, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

@gzotti gzotti marked this pull request as ready for review January 21, 2023 16:51
src/core/StelTexture.cpp Outdated Show resolved Hide resolved
src/core/StelTexture.cpp Outdated Show resolved Hide resolved
src/core/StelTexture.cpp Outdated Show resolved Hide resolved
@gzotti gzotti merged commit fb1fa62 into master Jan 22, 2023
@gzotti gzotti deleted the allow-texture-decimation branch January 22, 2023 12:51
@github-actions
Copy link

Hello @gzotti!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@github-actions
Copy link

Hello @gzotti!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Mar 13, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality importance: medium A bit annoying, minor miscalculation, but no crash
Development

Successfully merging this pull request may close these issues.

Stellarium Crashes on Raspberry Pi 3B(+)
3 participants