Work around too much stretching of close button icon on Qt 5.12.8 #2674
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
|
Qt5.12.8 is the version used for our Windows releases. Alexander said the ANGLE does not work properly with later versions. Most users will hopefully be able to step to Qt6-based builds, so a tiny bit of blur should be acceptable. |
AppImage for linux is based on Qt 5.12.8 too |
Is there a good reason for this? |
Ubuntu 20.04 have Qt 5.12.8 in standard repos |
Isn't the point of AppImage to be independent from the repos and self-contained? |
Yes, but it's depend on libc, so, if AppImage built on Ubuntu 22.04 then if cannot be run on Ubuntu 20.04 for example. Ubuntu 18.04 is good choice, but, cmake and Qt are too old and we cannot use it... P.S. Of course I can try get the AppImage on Ubuntu 18.04 to run the package on RHEL/CentOS |
|
On Ubuntu 20.04 you can use Qt 5.15 from |
Is there fixed a huge RAM usage for lconvert/lupdate tools? |
|
It became much better in 5.15.2, but still uses a lot. I have no access to later versions. |
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
In Qt 5.12 after #2660 the close button's icon appears to be overly stretched, like in the screenshot below. This happens in both scaled and unscaled UI.
This patch works around this by requesting a downsampled 16×16 pixmap from the original icon and rendering from it—only on Qt<5.13. This works fine for unscaled UI, but still looks ugly for scaled one:
I think this might be acceptable if we assume that Qt 5.12 is only going to be used on low-end systems which will not have high-DPI monitors anyway.