Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement for the AstroCalc/Positions tool #2549

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Enhancement for the AstroCalc/Positions tool #2549

merged 1 commit into from
Aug 3, 2022

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Aug 3, 2022 •
edited
Loading

Description

A small didactic enhancement for AstroCalc/Positions/HEC tool. The HEC chart & table can show 5 selected minor bodies (Pluto, Ceres, Juno, Pallas, Vesta) in additional to the major planets of Solar system. The list of selected minor planets followes the AstroCalc/Phenomena tool and Astronomical Almanacs.

The enhancement was added just for fun by the didactic purpose.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added the enhancement Improve existing functionality label Aug 3, 2022
@github-actions github-actions bot requested a review from gzotti August 3, 2022 14:52
@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited by alex-w
Loading

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Hello @alex-w! Thank you for this enhancement.

@alex-w alex-w added this to the 0.22.3 milestone Aug 3, 2022
gzotti
gzotti approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice!

@alex-w alex-w merged commit 860b3df into master Aug 3, 2022
@alex-w alex-w deleted the enhancement/astrocalc-positions branch August 3, 2022 15:24
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Sep 10, 2022
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti approved these changes

Assignees

@alex-w alex-w

Labels
enhancement Improve existing functionality
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-w @gzotti