Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in AstroCalc Planetary Transits #2491

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Fix bugs in AstroCalc Planetary Transits #2491

merged 1 commit into from
Jun 19, 2022

Conversation

worachate001
Copy link
Member

Description

In AstroCalc/Eclipses & transits tool (in development). There are bugs in rare cases.

  1. Partial/grazing transits that only visible in some parts of the world.
  2. Transits that occur around sunset/sunrise. Observable duration becomes more complicate to compute in certain (small) area of visibility on Earth's surface.

This patch should give correct result for those scenarios.

Examples:

Geocentric

  • No transit: 960 October 28 (but partial transit is visible in some parts of the world, Lat. +40, Long. -70, for example)
  • Partial transit: 1342 October 21, 1937 May 11

Topocentric

  • Total & partial transit: 1999 November 16 at Lat. 0, Long. +150 (total transit) / Lat. -60, Long. +150 (partial transit)
  • No transit & partial transit: 1937 May 11 at Lat. +60, Long. 0 (no transit) / Lat. -30, Long. 0 (partial transit)
  • Transit begins --> sunset --> sunrise --> transit ends: 2012 June 5/6 Lat. +60, Long. -20

I'll continue to test this tool to search for other potential bug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 10
  • Graphics Card: NVidia Geforce RTX

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w added this to the 0.22.2 milestone Jun 18, 2022
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alex-w alex-w merged commit cfec23b into Stellarium:master Jun 19, 2022
@worachate001 worachate001 deleted the fix-planetary-transits branch June 19, 2022 02:56
@github-actions
Copy link

Hello @worachate001! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @worachate001! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants