Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cardinals #2352

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Refactor cardinals #2352

merged 4 commits into from
Mar 18, 2022

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Mar 17, 2022

Description

This should provide correctly oriented compassmarks and cardinal markers

TODO

  • Compass Marks
  • Cardinal markers

Fixes #2174

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Win10
  • Graphics Card: Geforce 960M

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Start moving compassMarks to GridlinesMgr
This makes them usable in planetarium domes.
@gzotti gzotti added the enhancement Improve existing functionality label Mar 17, 2022
@gzotti gzotti added this to the 0.22.0 milestone Mar 17, 2022
@gzotti gzotti self-assigned this Mar 17, 2022
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@github-actions
Copy link

Hello @gzotti! Thank you for this enhancement.

@gzotti gzotti marked this pull request as ready for review March 17, 2022 23:09
@github-actions github-actions bot requested a review from alex-w March 17, 2022 23:09
@alex-w alex-w merged commit 9e20696 into master Mar 18, 2022
@alex-w alex-w deleted the refactor-cardinals branch March 18, 2022 05:54
@github-actions
Copy link

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @gzotti! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

Successfully merging this pull request may close these issues.

Gravity labels for the horizon
2 participants