Refactor: getAngularSize->getAngularRadius

[gzotti]

It occurred to me that we need to rename this method to clarify that these values are in fact radii, not sizes
See the documentation in StelObject.h

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update

TODOs

• Rename method
• add default implementation to StelObject base class
• clarify CustomObject's weird size
• clarify Nebula's intermediate result. Better return majorAxisSize/2? Adapt other code accordingly.
• clarify why MeteorShowers, Quasars, Pulsars, Exoplanet systems, Novae, Supernovae have non-zero but some distinct fixed small radii? Proposal: remove method override to inherit StelObject's zero size.
• clarify for the Satellite class what RCS is (document the variables!!!) and how to derive radius, not diameter (as it is maybe now), from that. Adapt other places in the satellites code accordingly!

How Has This Been Tested?

Test Configuration:

• Operating system: Win10 (irrelevant)
• Graphics Card: irrelevant

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

[gzotti]

@alex-w several classes have small arbitrary but distinctly non-zero sizes. The size for stars is zero. Why not also for these classes? A non-zero value implies we could enlarge it to see more than a dot.
The Nebula and Satellite I think do not follow the specification and return diameters, not radii. This should be fixed finally in this branch.

[gzotti]

@alex-w I have added 2 TODO annotations in the StelObject::getInfoMap(): I don't understand the test for negative values. (Just add an assert if in doubt?) And why do we need size in radians?

[alex-w]

@alex-w I have added 2 TODO annotations in the StelObject::getInfoMap(): I don't understand the test for negative values. (Just add an assert if in doubt?) And why do we need size in radians?

I don't remember details, probably this part was added into map to backward compatibility. I think we may delete this data.

[alex-w]

@alex-w several classes have small arbitrary but distinctly non-zero sizes. The size for stars is zero. Why not also for these classes? A non-zero value implies we could enlarge it to see more than a dot.

I've refactor this stuff. The most of these non-zero values was added a long time ago (around series 0.11-0.12) and probably on some step of refactoring we just forgot the fix this points.

[gzotti]

I think I caught all cases now.

[alex-w]

Thanks!

[github-actions]

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @gzotti! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest