Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new actions for jumping to specific events #2106

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Dec 16, 2021

Added new actions for jumping to defined moments in diurnal motion of selected objects.

Description

I've added 6 new actions with empty shortcuts, which allow users jumping to defined moments in diurnal motion of selected objects. For example you selected Jupiter on some altitude this evening and you can now jumping to the moment when Jupiter reaches current altitude this morning, next evening and morning, and previous evening and morning.

See idea in issue #484

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

I've assign shortcuts to the new actions and runs these shortcuts

Test Configuration:

  • Operating system: macOS Monterey (12.0.1)

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested a review from gzotti December 16, 2021 13:09
@alex-w alex-w added the feature Entirely new feature label Dec 16, 2021
@alex-w alex-w added this to the 0.21.3 milestone Dec 16, 2021
@github-actions
Copy link

github-actions bot commented Dec 16, 2021

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w removed the feature Entirely new feature label Dec 16, 2021
@alex-w
Copy link
Member Author

alex-w commented Dec 16, 2021

@Atque @A-j-K please comment this new feature (I've asked you as mature user of Stellarium with good astronomy background)

@Atque
Copy link
Contributor

Atque commented Dec 16, 2021

I have tried it now, and it works fine for me. This tool is very handy when selecting evenings/mornings to view Mercury.

BTW Windows complained when I tried to build first, because the file names were too long. You might want to rename the branch to something shorter.

@alex-w
Copy link
Member Author

alex-w commented Dec 16, 2021

BTW Windows complained when I tried to build first, because the file names were too long. You might want to rename the branch to something shorter.

Thanks for report!

@alex-w alex-w merged commit bd053ce into master Dec 16, 2021
@alex-w alex-w deleted the jump-to-defined-moments-in-diurnal-motion branch December 16, 2021 17:53
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants