Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: focus and tabbing #1971

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

GUI: focus and tabbing #1971

wants to merge 6 commits into from
+250 −50

Commits on Sep 19, 2022

  1. Indicate focus property for a few GUI elements

    @gzotti
    gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6743e04 View commit details
    Browse the repository at this point in the history

  2. Add a checkbox which can be toggled by pressing space bar

    @gzotti
    gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    9378502 View commit details
    Browse the repository at this point in the history

  3. CSS simplifications

    @gzotti
    gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    b2285f3 View commit details
    Browse the repository at this point in the history

  4. Add a space pressable pushbutton with focus highlight indicator

    @gzotti
    gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2edd4dd View commit details
    Browse the repository at this point in the history

  5. Contrib/gui/shortcuts/focus (#1991) 

    * re-enable focus policy
* review tab order due to re-enabled buttons
* allow tab focus on essential widgets only, and in this order:
- tree item
- search bar
- primary shortcut
- alt shortcut
- Apply

TODO: use new button classes which react to space presses when in focus
    @axd1967 @gzotti
    axd1967 authored and gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    b4ac39b View commit details
    Browse the repository at this point in the history

  6. Enabled help and keyboard shortcut dialogs with Space pressable push … 

    …buttons
    @gzotti
    gzotti committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0b0daf9 View commit details
    Browse the repository at this point in the history