Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cardinal points #1522

Merged
merged 2 commits into from
Feb 22, 2021
Merged

More cardinal points #1522

merged 2 commits into from
Feb 22, 2021

Conversation

Atque
Copy link
Contributor

@Atque Atque commented Feb 22, 2021

Description

This is a small change that will bring more cardinal points (north-northeast, east-northeast and so on).

Screenshots:

stellarium-074

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Test Configuration:

  • Operating system: Not relevant
  • Graphics Card: Really not relevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update src/translations.h file also!

@github-actions github-actions bot requested a review from alex-w February 22, 2021 11:11
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@alex-w alex-w merged commit 1bb804f into Stellarium:master Feb 22, 2021
@alex-w alex-w added this to the 0.21.0 milestone Feb 22, 2021
@alex-w alex-w added the enhancement Improve existing functionality label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

Successfully merging this pull request may close these issues.

2 participants