Make StelToneReproducer's xyYToRGB.glsl core function reusable #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, use appropriate names for variables, and write dot/matrix products as such instead of open-coding them.
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
|
Mmm.. I tried hard to keep these two commits separate to make |
|
ouch... sorry |
silas1037
added a commit
to silas1037/stellarium
that referenced
this pull request
Jan 15, 2021
Stellarium#1468)" This reverts commit f533b8b.
silas1037
added a commit
to silas1037/stellarium
that referenced
this pull request
Jan 15, 2021
Stellarium#1468)" This reverts commit f533b8b. it has bugs on Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to avoid duplication of the tone reproducer's code when I add the second atmosphere model, so these commits make it reusable (and more readable).