Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteSync issues with Qt5 #3304

Closed
gzotti opened this issue Jul 5, 2023 · 3 comments · Fixed by #3307
Closed

RemoteSync issues with Qt5 #3304

gzotti opened this issue Jul 5, 2023 · 3 comments · Fixed by #3307
Assignees
@10110111
Labels
bug Something likely wrong in the code
Milestone
23.3

Comments

@gzotti
Copy link
Member

gzotti commented Jul 5, 2023

Expected Behaviour

Stable Connection

Actual Behaviour

During first connection, connection fails at StelCore.ditheringMode and refuses to connect

Steps to reproduce

Run Qt5-based build

It seems the enum DitheringMode is not properly registered in the meta system. Qt6 makes this easier, there we have no more issue (after #3303).

System

  • Stellarium version: 23.2-qt5
  • Operating system: Win11
  • Graphics Card: irrelevant

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
@gzotti gzotti added the bug Something likely wrong in the code label Jul 5, 2023
@gzotti gzotti added this to the 23.3 milestone Jul 5, 2023
@gzotti
Copy link
Member Author

gzotti commented Jul 5, 2023

@10110111 can you please have a look into this? QVariant cannot decode a transmitted DitheringMode.

10110111 added a commit to 10110111/stellarium that referenced this issue Jul 5, 2023
@10110111
Fix behavior of DitheringMode with QVariant in Qt5
d4a5b01 
Fixes Stellarium#3304
@10110111 10110111 mentioned this issue Jul 5, 2023
Merged
10110111 added a commit to 10110111/stellarium that referenced this issue Jul 6, 2023
@10110111
Fix behavior of DitheringMode with QVariant in Qt5
7e89ba7 
Fixes Stellarium#3304
10110111 added a commit to 10110111/stellarium that referenced this issue Jul 6, 2023
@10110111
Fix behavior of DitheringMode with QVariant in Qt5
e49a0dc 
Fixes Stellarium#3304
10110111 added a commit to 10110111/stellarium that referenced this issue Jul 6, 2023
@10110111
Fix behavior of DitheringMode with QVariant in Qt5
0aa7b83 
Fixes Stellarium#3304
gzotti pushed a commit that referenced this issue Jul 6, 2023
@10110111
Fix behavior of DitheringMode with QVariant in Qt5 (#3307)
018c706 
Fixes #3304
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jul 15, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@10110111 10110111

Labels
bug Something likely wrong in the code
Milestone
23.3
Development

Successfully merging a pull request may close this issue.

Fix behavior of DitheringMode with QVariant in Qt5 10110111/stellarium
3 participants
@alex-w @10110111 @gzotti