Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] version numbers in 1.1 / 1.1.1 release broken #2805

Closed
core-code opened this issue Nov 1, 2022 · 6 comments
Closed

[macOS] version numbers in 1.1 / 1.1.1 release broken #2805

core-code opened this issue Nov 1, 2022 · 6 comments
Assignees
Labels
bug Something likely wrong in the code infrastructure Infrastructure related issues
Milestone

Comments

@core-code
Copy link

if you select the 1.1 (or is it 1.1.1 ?) release in the Finder, it claims to be version: 0.22.4-8cc1565

you did forget to update the CFBundleVersion and CFBundleShortVersionString entries.

also, the fact that the new release is labeled as 1.1 in GitHub but as 1.1.1 in the filenames, doesn't exactly make things easier for downstream.

thanks!

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w alex-w added this to the 1.2 milestone Nov 1, 2022
@alex-w alex-w self-assigned this Nov 1, 2022
@alex-w alex-w added the infrastructure Infrastructure related issues label Nov 1, 2022
@alex-w
Copy link
Member

alex-w commented Nov 1, 2022

if you select the 1.1 (or is it 1.1.1 ?) release in the Finder, it claims to be version: 0.22.4-8cc1565

Well, it should be 1.22.4 for universal package, so, the version 0.22.4-8cc1565 is definitely wrong here. Plus we have public and inner versions now. The inner version using for splitting Qt5-based and Qt6-based binaries and public version for source code, because 0.22.4 and 1.22.4 had identical code base.

you did forget to update the CFBundleVersion and CFBundleShortVersionString entries.

A both values generated automatically, but OK, I'll switch to use public versions for macOS bundles.

also, the fact that the new release is labeled as 1.1 in GitHub but as 1.1.1 in the filenames, doesn't exactly make things easier for downstream.

Immediately after releasing version 1.1 we found critical issue in Qt5-based binaries and after adding hotfix for it (one line fix!) we're re-generate all binaries. So, files reflect one hotfix for version 1.1 now.

@alex-w alex-w added the bug Something likely wrong in the code label Nov 1, 2022
@alex-w alex-w closed this as completed in 888a8ee Nov 1, 2022
@core-code
Copy link
Author

thanks

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 20, 2022
@github-actions
Copy link

Hello @core-code!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @core-code!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@core-code
Copy link
Author

thanks i can confirm this is resolved now. new version is called "1.2" and also has the embedded version number "1.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code infrastructure Infrastructure related issues
Development

No branches or pull requests

2 participants