Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon button for Online Queries is the same as Show Coordinates For Mouse Pointer #2710

Closed
Keatah opened this issue Oct 1, 2022 · 19 comments
Closed
Assignees
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Milestone

Comments

@Keatah
Copy link

Keatah commented Oct 1, 2022

Two buttons have the same icon. One of them matches it's function, the "Show coordinates of the mouse pointer". Makes sense, a pointer and crosshair..

The other, "Show window for Online Queries" isn't a good fit. Seems like it should have a different design or something.

Win10
stellarium-1.22.3-win64.exe
If you need more info I will provide it.

stellarium-002

@gzotti gzotti added the state: confirmed A developer can reproduce the issue label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Hello @Keatah!

OK, developers can reproduce the issue. Thanks for the report!

@gzotti
Copy link
Member

gzotti commented Oct 1, 2022

Yes I also have seen it. But too late. (It used to be different...)

@gzotti gzotti added this to the 1.1 milestone Oct 1, 2022
@10110111
Copy link
Contributor

10110111 commented Oct 1, 2022

It used to look like this:

bt_OnlineQueries_Off

The SVG sources, though, don't have the question mark, that's why the regenerated icon lost it.

I wonder though, why it even looked like a pointer touching a coordinate grid, even if with a question mark. Does such an icon make sense?

@gzotti
Copy link
Member

gzotti commented Oct 1, 2022

I admit I am bad with icon design. The crossmark with mouse arrow implies a target, and the question mark a query. In total "what's here".
I am open for better designs that read "look for online information about that thing here at the mouse cursor"

@10110111
Copy link
Contributor

10110111 commented Oct 1, 2022

I admit I am bad with icon design.

That's OK, me too :D

In total "what's here".

This sounds convincing enough. I suppose then, I'll just edit the SVG icon to add a question mark, and regenerate the PNGs.

What font did you use for the question mark?

@gzotti
Copy link
Member

gzotti commented Oct 1, 2022

OMG. Whatever I found in Photoshop. This was just something quick... Maybe also @martinber can suggest something better?

@alex-w alex-w added the bug Something likely wrong in the code label Oct 1, 2022
@10110111
Copy link
Contributor

10110111 commented Oct 2, 2022

Does this look acceptable as a fix?

a

@martinber
Copy link
Contributor

I would go fo something like a "help cursor" icon

image

For consistency I used the same question mark font as the help window already present. I don't want to use the same crosshair because it would be too similar to "show coordinates of mouse pointer". I will try now to think how to represent a target better

@gzotti
Copy link
Member

gzotti commented Oct 2, 2022

Yes, that's also OK. Is there any standardized icon element to put "web" into the interpretation?

10110111 added a commit that referenced this issue Oct 2, 2022
It was identical to that of Pointer Coordinates plugin because the
initial low-resolution PNGs were created directly ignoring the SVG
source.
Now the SVG source was edited, and the new PNGs are regenerated from it.

Issue #2710
@10110111
Copy link
Contributor

10110111 commented Oct 2, 2022

I will try now to think how to represent a target better

OK, for now I've pushed what I had in a comment above. Leaving this issue open for the time when we have a final alternative icon.

@martinber
Copy link
Contributor

Which one do you think is more clear?

image

image

@alex-w
Copy link
Member

alex-w commented Oct 2, 2022

Left bottom

@10110111
Copy link
Contributor

10110111 commented Oct 2, 2022

IMO, the clearest one that shows the intent is the star+pointer+questionMark.

Maybe the star could be replaced with a Saturn-like planet, because the star seems too overloaded a concept, especially a five-pointed one.

@gzotti
Copy link
Member

gzotti commented Oct 2, 2022

I agree, left bottom. It can be read as "search worldwide". Right center is what I had in my mind earlier today, "what does the www say about this". But it's characters, so left bottom is better.
Replacing the star by Saturn is not good IMHO as it implies "planet". So far almost all addressed sites (except Wikipedia) look for stars.

@10110111
Copy link
Contributor

10110111 commented Oct 2, 2022

OK, the bottom-left one reflects the plugin name, Online Queries, without any hint at mouse-pointing, so maybe it's the best then.

@martinber
Copy link
Contributor

martinber commented Oct 2, 2022

Tried some more and I think both top ones are good enough. The only problem with the top-left is that it is similar to equatorial and azimuth grids

image

Will do the top left one

martinber added a commit to martinber/stellarium that referenced this issue Oct 2, 2022
@alex-w alex-w closed this as completed in bd2893a Oct 2, 2022
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 12, 2022
@github-actions
Copy link

Hello @Keatah!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 31, 2022
@github-actions
Copy link

Hello @Keatah!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@Keatah
Copy link
Author

Keatah commented Oct 31, 2022

Love all the active development happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Development

No branches or pull requests

5 participants