Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: modernize doctests #282

Merged
merged 1 commit into from
May 10, 2024
Merged

chore: modernize doctests #282

merged 1 commit into from
May 10, 2024

Conversation

Stebalien
Copy link
Owner

We no longer need wrapping "main" blocks.

@Stebalien
chore: modernize doctests
657f0df 
We no longer need wrapping "main" blocks.
@Stebalien Stebalien requested a review from KodrAus April 16, 2024 22:38
simlay
simlay approved these changes May 10, 2024
View reviewed changes
Copy link

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this repo super well and I am just some random person from GitHub but I did read through these changes and found these changes nicer to read. I'm also a sucker for a PR with a lot more deletions than additions.

@Stebalien Stebalien merged commit e5418bd into master May 10, 2024
13 checks passed
@Stebalien Stebalien deleted the steb/modern-doctest branch May 10, 2024 19:13
@Stebalien
Copy link
Owner Author

Thanks! I forgot I pushed this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlay simlay simlay approved these changes

@KodrAus KodrAus Awaiting requested review from KodrAus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @simlay