feat: display settings in preferences #13
Conversation
| /// <summary> | ||
| /// Use to define custom tabbed menu | ||
| /// </summary> | ||
| /// <param name="tabsButtons"><see cref="ButtonStrip"/> buttons used to switch between tabs</param> | ||
| /// <param name="tabsContainer"><see cref="ScrollView"/> the container that will display the contents of the tabs</param> | ||
| public TabController(ButtonStrip tabsButtons, ScrollView tabsContainer) | ||
| { | ||
| m_TabsButtons = tabsButtons; | ||
| m_TabsContainer = tabsContainer; | ||
|
|
||
| Init(); | ||
| } |
There was a problem hiding this comment.
Let's avoid keeping unused constructor(all unused code). When it will be necessary it will be added as separated task
| if (!m_Tabs.Any()) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This part of code can be used before foreach (var tab in m_Tabs) to avoid additional foreach state check
| SettingsScope.User, | ||
| new[] { "stan", "plugin", "dev", "kit" }) | ||
| { | ||
| label = "About" |
There was a problem hiding this comment.
I guess it must be - Plugin Dev Kit
| } | ||
|
|
||
| var packageInfo = GetPackageInfo(); | ||
| rootElement.Q<Label>("display-name").text = packageInfo.displayName.Remove(0, "Stans Assets - ".Length); |
There was a problem hiding this comment.
typos in Stans assets -> Stan's Assets
There was a problem hiding this comment.
Good work! But still needs some love.
Added the video + script below with all the details.
bandicam.2023-05-10.12-54-35-613.mp4
- Switching between Group and page
- Changes doesnt represent when 2 winows are open
- TabController mimics base PackageWindow
- Registration process (attribute)? Activator.CreateInstance?
3.1 GetPackageInfo should reused for registration (keywords, name etc) - PackagePreferencesWindow.cs line 31
- CONTRIBUTING.md meta spams (foundation package update from 1.0.16 to 1.0.27)
yurii-lunha-stansassets
requested review from
kostiantyn-koretskyi and
pavlo-klymentenko-legacy
… with TabController
|
Fixed - Switching between Group and page Please take a look at #12 - I need these changes for other features too |
|
All the changes merged with newer PR, that's why this PR is going to be closed. |
Purpose of this PR
Implemented feature #11
Testing status
Manual testing status
Tested manually in using for the Package Manager plugin
Comments to reviewers
1. Added the About page in user preferences (screenshot), which will display "about us" info and at the same time I referenced its code as a simple example of implementing preferences window. What do you think about it?
2. Implemented public TabController that can be useful for developing other plugins, and StansAssets.Plugins.Editor.PackageSettingsWindow<> can use it too (instead of ButtonStrip+ScrollView). It would be better to add it in another PR but PackagePreferencesWindow is dependent on it.
About page
Reference example
