Simplfy the data.sqlite3 #1172
Merged
Simplfy the data.sqlite3 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of SpiNNakerManchester/SpiNNFrontEndCommon#1207
Notes:
This now writes a row to range data table even if the data read is empty! This allows distention between successfully read data of length zero (ok) and did not read any data (an error)
The python side normally fills in the extraction table so that i just mocked here for unittests.
getRecordingRegionContents is simpler that python because 1. It is just used for testing, 2. ByteArrayOutputStrea does not need to be setup with size.