Exclusion Strategy #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @Spea |
miguelgf
force-pushed
the
feature/exclusionstrategy
branch
from
a0794b4
to
c1a596b
Compare
Spea
reviewed
Dec 20, 2016
| $this->dumper->dump('/foo', 'php'); | ||
| } | ||
|
|
||
|
|
| * @return boolean true, if this class should be skipped | ||
| */ | ||
| public function shouldSkipClass(ClassMetadata $metadata); | ||
| } |
There was a problem hiding this comment.
Always add a new line at the end of the file
| /** | ||
| * Indicates if this class should be skipped and do not generate fixtures for this class | ||
| * | ||
| * @param $metadata |
| @@ -2,3 +2,5 @@ vendor/ | |||
| bin/ | |||
| phpunit.xml | |||
| composer.lock | |||
|
|
|||
| .idea/* | |||
There was a problem hiding this comment.
IMO this should be in your global .gitignore, but you can keep it here aswell.
Spea
reviewed
Dec 21, 2016
| return in_array(ClassUtils::getClassName($metadata->getName()), $this->skipClassesNames) || | ||
| in_array($metadata->getName(), $this->skipClassesNames); | ||
| } | ||
| } |
|
Thx for the PR. Will create a new release sometime today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posibility to define a strategy to exclude some entities to be dumped. Includes an implementation of this strategy to define an array of class names or FQN to be excluded.
Closes #12