Removes unnecessary 'token' param from request to Slack for user info. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its presence causes 'invalid_auth' error because Slack API now requires token to be passed in Authorization header.
|
@robot-soul Thanks for opening a PR to fix this issue! I'm super slammed right now, and it would be really helpful if you could give me a link to the line of code where it sends the token within the auth header so I can verify. Otherwise I'll take a look when I have a spare minute and merge/release a patch update. |
|
Hey @athix - no problem! Thanks for the prompt response :) I think this happens in the oauth2 gem: |
joshbuker
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Per @robot-soul, looks like the token is passed as a part of the OAuth2 gem, and none of the other providers have the token passed manually. Seems reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack API now requires token to be passed in Authorization header instead of query params. Passing it in params causes 'invalid_auth' error.
The token is already being correctly passed in the Authorization header so this PR just removes the token from the query params.