Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Battlenet Provider #260

Merged
merged 7 commits into from
Nov 29, 2020
Merged

Add Battlenet Provider #260

merged 7 commits into from
Nov 29, 2020

Conversation

jojoa
Copy link
Contributor

@jojoa jojoa commented Oct 26, 2020

I Added BattleNet as OAuth Provider as documented in theri api docu and tested it local.

Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance! I'll take a closer look at this when I can and merge it into master.

Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things I noticed.

lib/sorcery/providers/battlenet.rb Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/generators/sorcery/templates/initializer.rb Outdated Show resolved Hide resolved
lib/sorcery/providers/battlenet.rb Outdated Show resolved Hide resolved
Add Site config to initializer
@jojoa jojoa requested a review from joshbuker November 15, 2020 20:34
Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jojoa looks good other than the eu.battle.net concern. Do you have time to look into their documentation? A link to their docs where it talks about which subdomains to use would be helpful for me to better understand their implementation of OAuth2.

@jojoa
Copy link
Contributor Author

jojoa commented Nov 17, 2020

@jojoa looks good other than the eu.battle.net concern. Do you have time to look into their documentation? A link to their docs where it talks about which subdomains to use would be helpful for me to better understand their implementation of OAuth2.

I ve tested it. i can succesfully use the us domain with my eu account. so i think there are no problems. the doc says that only CN has an seperate Data Department. But i am not sure how this could be implemented. also the game infos could be different, but the general login info is same. so i dont think it is important for an auth Gem to have things like the Wow chars.

@jojoa
Copy link
Contributor Author

jojoa commented Nov 17, 2020

https://develop.battle.net/documentation/guides/regionality-and-apis

@joshbuker joshbuker self-requested a review November 18, 2020 07:06
@jojoa
Copy link
Contributor Author

jojoa commented Nov 29, 2020

any news here?

Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything is broken, it should only affect people using this specific provider and can be fixed with a later update. Going to go ahead and merge this for now.

@joshbuker joshbuker merged commit d16fffa into Sorcery:master Nov 29, 2020
@joshbuker
Copy link
Member

@jojoa You should be able to use this by pointing your Gemfile at the master branch of Sorcery via Github. I'm planning on focusing on the v1 release of Sorcery over the next week, so I probably won't cut a new release until after that's ready to deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants