Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use id instead of uid for VK provider #199

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Conversation

anaumov
Copy link
Contributor

@anaumov anaumov commented Jul 16, 2019

VK has changed the API and it returns user_info in such way

{
  email: 'someone@vk.com',
  id: 12300321
}

Therefore user_hash[:user_info]['uid'] is nil and sorcery does not create authentication for user. This patch should fix this.

Not sure how to add spec for this case. Let me know if you have any questions.

@anaumov
Copy link
Contributor Author

anaumov commented Jul 31, 2019

@athix can you take a look?

@joshbuker
Copy link
Member

I'm currently slammed, but I'll try to get caught up with Sorcery as soon as possible.

@joshbuker joshbuker merged commit 8d2d0a5 into Sorcery:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants