Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonnet V2.0.2 #119

Merged
merged 25 commits into from
Nov 22, 2023
Merged

Sonnet V2.0.2 #119

merged 25 commits into from
Nov 22, 2023

Conversation

ultrabear
Copy link
Member

@ultrabear ultrabear commented Nov 21, 2023 •
edited
Loading

There are some minor bugfixes and QoL improvements that have been sitting for a while now

Checklist:

  • Run codespell
  • Open new version PR (dev-unstable -> main)
  • Pass code review on new version PR
  • Remove -dev tags from sonnet core modules (cmds and dlibs)
  • Ensure all updated cmds and dlibs receive new version
  • Decide on name for new version
  • Locally create toml changelog in sonnet-website repository by referencing new version PR diff and commit history
  • Locally update command reference on website using cmds_to_html.py
  • Locally update latest version download link on website
  • Export changelog without name to draft gh release and PR, using a new git tag for the new version

@ultrabear
patches for new lints
4849cf5
@ultrabear
patches for new lints
976d523
@ultrabear
add special exception to set-whitelist command
dd634b5
@ultrabear
patch yousaidhowfast_Cedition to enforce the CDLL being loaded properly
644fdd6
@ultrabear
push LeXdPyK 2.0.5: mypy patches
8189005
@ultrabear
add design doc to tree, this should be updated later to be more compr…
73eb655 
…ehensive
@ultrabear
patch for CVE-2023-23931
31db620
@ultrabear
add dev flags again
0db1148
@ultrabear
patch starboard imageurl parser for discord adding trackerparms to at…
aa05a12 
…tachments
@ultrabear
add ruff to autotest and apply starter lints for it
f2b1959
@ultrabear
add ruff to workflows
8b9fc2e
@ultrabear
actually install ruff in the dev workflow
7ab2643
@ultrabear
apply latest ruff lints (and ignore single line exprs for now)
7ee809c
@ultrabear
wait go back thats not correct
f03673a
@ultrabear
add pluralize helper fn and fix server-info roles not being pluralize…
29d6b5e 
…d properly
@ultrabear
add command-from-message parser to lib_sonnetcommands
2df7dc8
@ultrabear
use parse_command_novalidate in on_message
bfdcc10
@ultrabear
make set-whitelist escape hatch parse commands properly
74b9026
@ultrabear
pass necessary escape clientuser to set-whitelist escape processor
8b0770f
@ultrabear
add 3.10 to CI as test
ceea0e8
@ultrabear
add a release checklist so i stop messing it up
d963f63
@ultrabear
fix codespell errors
1f474f3
@ultrabear
Copy link
Member Author

new pyright version gave an error lol
1.1.335 was broken on sonnet so i kept using 1.1.334 but 1.1.336 seems to have fixed it

@ultrabear
Remove useless overload from lib_lexdpyk_h as reported by pyright
7a7c44e 
If I remember right that overload was left in because mypy or pyright
previously could not handle the typesignatures properly.
It seems to work now, any hacks for typeck failures should be commented
over though.
bredo228
bredo228 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@bredo228 bredo228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ultrabear
Copy link
Member Author

Sonnet V2.0.2

Frontend

  • Update(set-whitelist): Calling set-whitelist is now whitelisted for guild owners always regardless of blacklist settings
  • Update(mention-hint): Sonnet now has a more advanced hint, which displays not only the prefix but how to access help, and how to use the mention prefix

Under the Hood

  • Add(ruff): New linter pass over codebase
  • Update(LeXdPyK): 2.0.5: Patch mypy errors
  • Refactor(ruff): Various small changes that ruff suggested
  • Add(sonnetcommands): parse_command_novalidate that parses a command name and arguments from any supported prefix
  • Refactor(mypy/pyright): Apply new lint suggetions since the last time mypy/pyright was run
  • Add(design): Markdown file containing general design guidelines for sonnet
  • Add(checklist): Release checklist for new sonnet versions

Runtime Environment

  • Update(cryptography): Raise min version to patch out CVE
  • Change(wordlist): Differentiation was mispelled as differentiaton, spellchecked
  • Add(py310): Python 3.10 to development CI, Sonnet might deprecate python 3.8 in the future, and this will ensure it works on the new target

Bugs

  • Fix(starboard): Attached images not being shown due to trackerparams being added to url
  • Fix(server-info): Roles feild now properly pluralizes Roles to say Role when the count is 1

@ultrabear ultrabear merged commit 54992ca into main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bredo228 bredo228 bredo228 approved these changes

Assignees

@bredo228 bredo228

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ultrabear @bredo228