Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANGRADLE-152 Fix issue with "sonar.tests" in child modules #234

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ADarko22
Copy link
Contributor

@ADarko22 ADarko22 commented Jul 2, 2024

Child modules copy the "sonar.tests" property from the parent when it is not defined. This behavior is encoded in the scanner engine, and it breaks the logic defined in SCANGRADLE-152 causing doubled indexing.

… property from the parent when it is not defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿 Let's apply the comment change to make it easier on ourselves next time

Co-authored-by: Dorian Burihabwa <75226315+dorian-burihabwa-sonarsource@users.noreply.github.com>
@ADarko22 ADarko22 enabled auto-merge (squash) July 2, 2024 14:52
@ADarko22 ADarko22 merged commit 74a8f03 into master Jul 2, 2024
10 checks passed
@ADarko22 ADarko22 deleted the angelo/SCANGRADLE-152_fix_bug_with_sonar_tests branch July 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants