Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARGRADL-133 Fix Exception when adding Gradle Kotlin scripts if cus… #215

Merged
merged 1 commit into from
Mar 22, 2024
Merged

SONARGRADL-133 Fix Exception when adding Gradle Kotlin scripts if cus… #215

merged 1 commit into from
Mar 22, 2024

Conversation

leveretka
Copy link
Contributor

…tom 'sonar.sources' value is defined

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@leveretka leveretka marked this pull request as ready for review March 22, 2024 08:28
dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we can help with readability by extracting the test for the root of the project in a named method

src/main/java/org/sonarqube/gradle/SonarPropertyComputer.java Outdated Show resolved Hide resolved
@leveretka leveretka merged commit 9c2cc39 into master Mar 22, 2024
1 of 9 checks passed
@leveretka leveretka deleted the margo/SONARGRADL-133 branch March 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leveretka @dorian-burihabwa-sonarsource