Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-67 Fix FP S4782 (no-redundant-optional): Ignore when "exactOptionalPropertyTypes" is enabled #4829

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Please have a look also at this RSPEC change, where I mention the behavior of the rule if exactOptionalPropertyTypes is enabled.

Note that I leave the update of the HTML rule description for when we run the rule-api tool before the next release.

Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vdiez vdiez merged commit bec1017 into master Sep 18, 2024
15 of 16 checks passed
@vdiez vdiez deleted the JS-67 branch September 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants