JS-329 Upgrade TypeScript to 5.6.2

[saberduck]

Behavior wrt. project references has changed. Previously, if a project overlapped with the referenced project, it would include the files of the referenced project regardless. Now, the files from the referenced project are not included. This is better for us since it avoids analyzing the files duplicitly.

[pmaieref]

Hi, I was about to open a thread in the forum regarding the TypeScript update, but as I see this here now, I thought I might just ask here. If it is too off-topic, please tell me and I'll move it to the community forum.

I am wondering if there are any guidelines, processes, documentation on how TypeScript versions are handled within SonarQube / SonarJS. The documentation does not provide any insights into:

• Can my local project use a higher / lower TS version than SQ/SonarJS
  • Considering this PR makes it into SQ 10.7, do I need my project on TS 5.6 as well to work in SQ 10.7?)
• What is the release cadence of TS updates in SonarJS? I see that 5.5 was skipped and you update directly to TS 5.6. Considering TS 5.6 is now 4 days old, this update is "early" (thanks for that!), but "support" for TS 5.5 is quite late.
• How do certain TS compiler flags play into this? Does SQ need to explicitly support / drop support for them?

The project I am working on, strives to use current / up-to-date versions of Angular, but in the past SQ's TS version was a blocking issue that prevented updating Angular as they raise the minimum versions of TS every 6 months with every major update. We ran into (compilation / execution) issues due to different TS versions and had to downgrade again. Now we don't even try if it would maybe work and just wait it out.

Thanks in advance.

[gabriel-vivas-sonarsource]

Hi @pmaieref,

Indeed, I think this would be better to discuss in the Community.
I'll still provide an answer here while the PR is open :-)

We do regular upgrades as they come. However, sometimes conflicting dependencies prevent us from updating faster.

You should be fine using older versions of TypeScript. We don't officially support newer versions. You might experience issues with new compiler options, which can be solved with a dedicated tsconfig.sonar.json. In other cases, we won't yet support new syntax in files that use it, but the rest of your analysis might work well. YMMV.

Keep in mind that if you are using SonarQube, you'll only get the updates when SonarQube itself is released and you update.
The SonarQube releases happen every ~2 months (latest version) or every ~18 months (long-term version).

Hope that helps!

[pmaieref]

@gabriel-vivas-sonarsource Highly appreciated the reply. If needed I'll create a post in the forum for any further discussions. Yes, we keep our SQ always on latest, thanks. :)

Maybe you could discuss internally if a small update to https://docs.sonarsource.com/sonarqube/latest/analyzing-source-code/languages/javascript-typescript-css/ would make sense, i.e. adding some information regarding TS version support, tsconfig.sonar.json, etc..

Thank you very much for the quick reply here and good luck with the update! :)

[ilia-kebets-sonarsource]

@saberduck What are all the ruling diffs? Is there a general pattern?

[ilia-kebets-sonarsource]

It seems that all ruling issues disappeared from file packages/vuetify/src/components/VDatePicker/VDatePickerDateTable.ts

[ilia-kebets-sonarsource]

There are changes in the ruling for these rules which depend on the TS type checker:

• S4325: Redundant casts and non-null assertions should be avoided
• S1874: Code annotated as deprecated should not be used

and weirdly one issue gone for rule S6606: Nullish coalescing should be preferred in this location

and one weirder thing: All issues are gone from the vuetify:packages/vuetify/src/components/VDatePicker/VDatePickerDateTable.ts file.

[ilia-kebets-sonarsource]

What is null here?

[ilia-kebets-sonarsource]

see #4816

[ilia-kebets-sonarsource]

If you like the changes here, you should apply them to all the packages/ruling/tests/projects/*.ruling.test.ts files

[saberduck]

It seems that all ruling issues disappeared from file packages/vuetify/src/components/VDatePicker/VDatePickerDateTable.ts

It seems that on Mac, we reached Maximum call stack size exceeded in file vuetify:packages/vuetify/src/components/VDatePicker/VDatePickerDateTable.ts. I had to pass --stack-size=1000 for a ruling to pass on my Mac machine. On CI, the limit is probably higher (Linux). I will fix the CI in another PR so the failure is easier to debug.

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube