JS-54 Add rule S7060 Modules should not import themselves #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberduck
force-pushed
the
tibor/JS-54
branch
3 times, most recently
from
36ee97b
to
7fffc10
Compare
saberduck
force-pushed
the
tibor/JS-54
branch
from
7fffc10
to
8fa51ed
Compare
saberduck
force-pushed
the
tibor/JS-54
branch
from
8fa51ed
to
ddf0e77
Compare
| return; | ||
| } | ||
| const { node } = reportDescriptor; | ||
| let suggestion: Rule.SuggestionReportDescriptor | undefined; |
There was a problem hiding this comment.
Do you think we could turn the suggestion variable into an array that we would initialize to an empty array? By doing so, we could
- make it constant,
- push to it a quick fix only if possible, and
- avoid the ternary expression that conditionally injects the quickfix.
I am not entirely sure, but this should work since the suggest property of the report expects an array. We would report an empty array of suggestions if no quickfix applies.
|
|
||
| // DO NOT EDIT! This file is autogenerated by "npm run generate-meta" | ||
|
|
||
| export const meta = { |
There was a problem hiding this comment.
cc @victor-diez-sonarsource because I am not sure.
- Since the rule provides a quickfix, should the rule metadata include the key-value
fixable: 'code'? - Do we need to update the eslint-plugin README to include an entry for this new rule
no-self-import? If yes, how?
There was a problem hiding this comment.
- Yes, it should.
npm run generate-metashould put that field in themeta.tsfile if the rspec contains thequickfix === 'covered'attribute. Link - Yes, that is part of also of the
generate-metascript. You will see that it callscd packages/jsts/src/rules && npm run eslint-docs, which updates the README file.
There was a problem hiding this comment.
Thanks 👍
yassin-kammoun-sonarsource
approved these changes
Sep 11, 2024
| @@ -215,6 +215,7 @@ SonarJS rules for ESLint to help developers produce [Clean Code](https://www.son | |||
| | [no-same-argument-assert](https://sonarsource.github.io/rspec/#/rspec/S5863/javascript) | Assertions should not be given twice the same argument | ✅ | | | | | | | |||
| | [no-same-line-conditional](https://sonarsource.github.io/rspec/#/rspec/S3972/javascript) | Conditionals should start on new lines | ✅ | | 🔧 | 💡 | | | | |||
| | [no-self-compare](https://sonarsource.github.io/rspec/#/rspec/S6679/javascript) | "Number.isNaN()" should be used to check for "NaN" value | ✅ | | 🔧 | 💡 | | | | |||
| | [no-self-import](https://sonarsource.github.io/rspec/#/rspec/S7060/javascript) | Module should not import itself | ✅ | | | 💡 | | | | |||
There was a problem hiding this comment.
Suggested change
| | [no-self-import](https://sonarsource.github.io/rspec/#/rspec/S7060/javascript) | Module should not import itself | ✅ | | | 💡 | | | | |
| | [no-self-import](https://sonarsource.github.io/rspec/#/rspec/S7060/javascript) | Module should not import itself | ✅ | | 🔧 | 💡 | | | |
There was a problem hiding this comment.
actually not - this rule doesn't provide the fix , it's a bug in metadata generation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JS-54