Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SparkFun_APDS9960 to submodule #2800

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jun 11, 2024

Submodule allows easier maintenance and tracking of upstream changes.
Only one function change, addition of getStatusRegister function.

Also patch fixing issue flagged by clang build:

 /home/runner/work/Sming/Sming/Sming/Libraries/SparkFun_APDS9960/SparkFun_APDS9960.cpp:508:32:
warning: result of comparison of constant -1 with expression of type 'uint8_t' (aka 'unsigned char') is always false
[-Wtautological-constant-out-of-range-compare]
                if( bytes_read == -1 ) {
                    ~~~~~~~~~~ ^  ~~

@slaff slaff added this to the 5.2.0 milestone Jun 12, 2024
@slaff slaff merged commit 666c0c2 into SmingHub:develop Jun 12, 2024
38 checks passed
@mikee47 mikee47 deleted the fdeature/apds9660-submodule branch June 12, 2024 11:00
@slaff slaff mentioned this pull request Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants