Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client Websockets (broken) #2749

Merged
merged 16 commits into from
Apr 3, 2024
Merged

Fix client Websockets (broken) #2749

merged 16 commits into from
Apr 3, 2024

Commits on Mar 29, 2024

  1. Ensure WebsocketConnection::send releases source stream on failure

    mikee47 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2268dc0 View commit details
    Browse the repository at this point in the history

  2. Fix another leak in same file

    mikee47 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c1a5643 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Update Websocket_Client and add debug tools 

    Add `wsserver` build target with simple echo server
Use local server by default (remote website no longer exists)
Add `test.py` script to check connection protocol
Update sample to send both text and binary messages
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    705d56a View commit details
    Browse the repository at this point in the history

  2. Message Streams without known size are not supported when closing c… 

    …onnection
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    1ece779 View commit details
    Browse the repository at this point in the history

  3. XorOutputStream needs to take copy of provided mask data 

    Websocket client passes local mask data which can get corrupted, leading to unreliable messages.
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    91331b7 View commit details
    Browse the repository at this point in the history

  4. Fix Websocket client key generation

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    2ff3313 View commit details
    Browse the repository at this point in the history

  5. Send status code on close, and allow more time before closing connection

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    1adc98a View commit details
    Browse the repository at this point in the history

  6. Simplify key generation

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    b728a99 View commit details
    Browse the repository at this point in the history

  7. Simplify packet creation

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    8970ce2 View commit details
    Browse the repository at this point in the history

  8. Tidy

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    bdae2bd View commit details
    Browse the repository at this point in the history

  9. More robust WebsocketConnection initialisation to account for conne… 

    …ction == nullptr
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    172702f View commit details
    Browse the repository at this point in the history

  10. WebsocketConnection not getting destroyed 

    HttpConnection is NOT auto-self-destruct so we need to change that during closure.
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    64e3a3d View commit details
    Browse the repository at this point in the history

  11. Fix message reception 

    `HttpClientConnection` resets our `receive` delegate
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    aa03cd6 View commit details
    Browse the repository at this point in the history

  12. Don't handle CLOSE message until it's all been processed

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    ef7613d View commit details
    Browse the repository at this point in the history

  13. Tidy close() method

    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    46e8ff9 View commit details
    Browse the repository at this point in the history

  14. Must always send a CLOSE message 

    Can either be in response to a received CLOSE, or as an outgoing notification.
Only difference is in the status code sent.
    mikee47 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    47d7fa2 View commit details
    Browse the repository at this point in the history