Fix Esp32 hardware timer callbacks #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2024 12:27
PR SmingHub#2697 was supposed to fix the WDT from hardware timer interrupts. It did this by disabling interrupts (and therefore callbacks) completely. The actual reason for the WDT is twofold: 1. IDF version 5 changed some low-level HAL calls to accept bit masks instead of timer index. 2. Argument to interrupt callback wasn't stored or passed correctly so user-provided callback got junk for this parameter.
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3.5 - Approved - Waiting for CI results
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix esp32 hardware timer callbacks
PR #2697 was supposed to fix the WDT from hardware timer interrupts.
It did this by disabling interrupts (and therefore callbacks) completely.
The actual reason for the WDT is twofold:
This PR fixes those issues and fixes incomplete testing in HostTests.
Also checked Basic_Blink sample using HardwareTimer.