Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CallbackTimer::start not in IRAM #2676

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 20, 2023

Known issue with templated code where compiler silently ignores section attribute. https://sming.readthedocs.io/en/latest/framework/core/pgmspace.html#templated-code. See also #2640.

Known issue with templated code where compiler silently ignores section attribute.
https://sming.readthedocs.io/en/latest/framework/core/pgmspace.html#templated-code
@what-the-diff
Copy link

what-the-diff bot commented Oct 20, 2023

PR Summary

  • Added __forceinline Attribute to the start Method
    Guarantees code will be in IRAM when required.

@slaff slaff added this to the 5.1.0 milestone Oct 20, 2023
@slaff slaff merged commit d85d10c into SmingHub:develop Oct 21, 2023
36 checks passed
@mikee47 mikee47 deleted the fix/timer-start-iram branch October 21, 2023 19:25
@slaff slaff mentioned this pull request Oct 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants