Fix Esp32 flashing #2613
Merged
Fix Esp32 flashing #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of problems related to ESP32 bootloader flashing.
The
make sdk-configcleanbuild target which currently does not full clear the SDK configuration information as expected.The bootloader debug log may show the
SHA-256 comparison failedmessage.The reason for this is that, by default, esptool will auto-detect flash settings and overwrite those values in the bootloader header. Those settings are the mode, speed and flash size settings.
This behaviour is now disabled (by setting CONFIG_ESPTOOLPY_FLASHSIZE_DETECT=n),
and the user-configured parameter values passed to the SDK.
This also fixes the problem for later versions of esptool (4+) which ignores auto-detect unless bootloader checksumming is also disabled. This results in boot failure as the flash chip size is usually too small (default is 2MB).