Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 Station::isEnabledDHCP() returns incorrect value. #2604

Merged
merged 1 commit into from
Jan 19, 2023
Merged

ESP32 Station::isEnabledDHCP() returns incorrect value. #2604

merged 1 commit into from
Jan 19, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 18, 2023

Called dhcps (server) function instead of dhcpc (client).

@what-the-diff
Copy link

what-the-diff bot commented Jan 18, 2023

  • The function esp_netif_dhcps_get_status() was changed to esp-netif-dhcpc.
  • This change is in the StationImpl class, which handles DHCP client functionality for ESP32 devices.
  • It appears that this change fixes a bug where the status of dhcp clients could not be retrieved properly on some platforms (e.g., Raspberry Pi).

@slaff slaff added this to the 4.8.0 milestone Jan 18, 2023
@slaff slaff merged commit 4cc43b1 into SmingHub:develop Jan 19, 2023
@mikee47 mikee47 deleted the fix/esp32-nwsta-dhcp branch January 19, 2023 08:17
@slaff slaff mentioned this pull request Feb 8, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff