Revise FixPath build function
#2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translates "" into "/" which is not only wrong but can do weird things in Windows. Let's just check various path permutations to make sure they're handled correctly. Test script: ``` define Check $(info FixPath "$1": "$(call FixPath,$1)") endef $(call Check,) $(call Check,C:\test) $(call Check,test) $(call Check,./test) $(call Check,/c/test) $(call Check,c:/test) ``` Run from `Basic_Blink` sample directory, we previously get this: ``` FixPath "": "/" FixPath "C:\test": "/C/test" FixPath "test": "/test" FixPath "./test": "/./test" FixPath "/c/test": "/c/test" FixPath "c:/test": "/c/test" ``` With this commit: ``` FixPath "": "" FixPath "C:\test": "/C/test" FixPath "test": "/s/sandboxes/sming-tmp/samples/Basic_Blink/test" FixPath "./test": "/s/sandboxes/sming-tmp/samples/Basic_Blink/test" FixPath "/c/test": "/c/test" FixPath "c:/test": "/c/test" ```
``` Fetching submodule 'jerryscript' ... rm: cannot lstat `jerryscript/jerry-core/api': Permission denied rm: cannot lstat `jerryscript/jerry-core/debugger': Permission denied rm: cannot lstat `jerryscript/jerry-core/ecma': Permission denied fatal: cannot create directory at 'jerry-core/api': Permission denied Unable to checkout 'd69ac0e070a97babb4b8e4c116db765f47c3eb02' in submodule path 'jerryscript' ``` This seems to be happening because jerryscript/jerryscript is already pulled in. Cannot explain why the above failure occurs, but avoiding recursive clone means the offending directories are not present and the fault disappears.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translates "" into "/" which is not only wrong but can do weird things in Windows.
Let's just check various path permutations to make sure they're handled correctly.
Test script:
Run from
Basic_Blinksample directory, we previously get this:With this commit: