Add Kconfig support #2374
Merged
Add Kconfig support #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
feature/kconfig
branch
from
7f3c7fc
to
618245b
Compare
|
Got the rough bones of this working, but choices need sorting out. For example, cannot set the DEBUG_VERBOSE_LEVEL value directly but need to work out which of the appropriate |
mikee47
force-pushed
the
feature/kconfig
branch
2 times, most recently
from
a602602
to
8c36a49
Compare
|
OK, seems to be working. |
Add cfgtool to convert between formats
Fix use of `SPIFF_FILEDESC_COUNT`
Cannot set `CONFIG_BOOTLOADER_LOG_LEVEL` directly, only through choice variables
mikee47
force-pushed
the
feature/kconfig
branch
from
8c36a49
to
9bbea2c
Compare
|
@mikee47 This PR so far looks great to me! Gradually we should add more visually configurable options to components, like for example SSL options and so on, but this can happen also in other PRs. Apart from fixing the codacy issues do you plan to add some more changes to this PR? |
mikee47
force-pushed
the
feature/kconfig
branch
2 times, most recently
from
0d68426
to
09a96cf
Compare
|
@slaff Tried and failed to resolve "No whitespaces allowed surrounding docstring text (D210)". (Looks like it's failed to pick up forced changes.) Also added fix so this works on Windows (paths issues). That should be all for now. |
Generate `kconfig.in` file using cfgtool, fix paths as required (e.g. "/s/path/to" -> "s:/path/to")
mikee47
force-pushed
the
feature/kconfig
branch
from
09a96cf
to
1f1180f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
menuconfigbuild target as per Slaff's idea in #1712 (comment).Sming configuration does not fully comply with Kconfig spec. For example, boolean values in Sming are typically '1', '0' or undefined but Kconfig requires them to be 'y' or 'n'. A small python program handles this conversion and merging Kconfig settings into the cached configuration data.
The current set of Kconfig files aren't complete but these can be added as required.