Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated bearssl to its latest version. #2240

Merged
merged 5 commits into from
Mar 7, 2021
Merged

Updated bearssl to its latest version. #2240

merged 5 commits into from
Mar 7, 2021

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Mar 4, 2021

No description provided.

@slaff slaff added this to the 4.3.0 milestone Mar 4, 2021
mikee47
mikee47 reviewed Mar 4, 2021
View reviewed changes
Sming/Components/ssl/component.mk Outdated
cd $(SSL_CERT_DIR); SSL_INCLUDE_DIR=$(SSL_INCLUDE_DIR) $(SSL_TOOLS_PATH)/make_certs.sh
$(Q) cd $(SSL_CERT_DIR); SSL_INCLUDE_DIR=$(SSL_INCLUDE_DIR) $(SSL_TOOLS_PATH)/make_certs.sh; rm -rf $(SSL_CERT_DIR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of those files may need to be kept; How about using out/ssl/cert instead?

@slaff slaff requested a review from mikee47 March 5, 2021 10:00
mikee47
mikee47 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've moved the openssl fix from #2224 as it occurs running openssl in all architectures.

@mikee47
Copy link
Contributor

mikee47 commented Mar 5, 2021

Just one other thing. I get rm: cannot remove 'srl': No such file or directory when certs are generated. In https://github.com/SmingHub/Sming/blob/develop/Sming/Components/ssl/Tools/make_certs.sh#L151 is this cleanup actually necessary?

@slaff
Copy link
Contributor Author

slaff commented Mar 5, 2021

Just one other thing. I get rm: cannot remove 'srl': No such file or directory when certs are generated.

I will change this to rm *.srl. Openssl keeps the serial number per certificate in x.srl.

is this cleanup actually necessary?

Well... these files are intermediate so they can be removed.

@slaff slaff merged commit 2242d29 into SmingHub:develop Mar 7, 2021
@slaff slaff mentioned this pull request Mar 7, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 mikee47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @mikee47 @slav-at-attachix