Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESP32 digital/analogue implementations #2188

Merged
merged 4 commits into from
Dec 31, 2020
Merged

Fix ESP32 digital/analogue implementations #2188

merged 4 commits into from
Dec 31, 2020

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Dec 30, 2020

Pins with analogue (RTC) functionality need extra attention.

  • Add ANALOG pin mode, set internally via analogRead (approach taken by arduino32)
  • Ensure RTC pins are configured correctly for digital mode. Input pullups need to be enabled/disabled in both primary and RTC IO blocks.
  • Internally, prefer use of gpio_ll_XX and rtcio_ll_XX functions as these map to macros which access hardware directly (as appropriate for ESP32, ESP32S2, etc) whilst avoiding RTOS locks, etc. which Sming does not (should not) require.

This was referenced Dec 30, 2020
Merged
Merged
@slaff slaff added this to the 4.2.0 milestone Dec 30, 2020
slaff
slaff reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@slaff slaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have to test it tomorrow on the ESP8266(s) and ESP32(s) that are lying around.

@slaff slaff removed the 3 - Review label Dec 31, 2020
@slaff slaff merged commit 82c143f into SmingHub:develop Dec 31, 2020
@mikee47 mikee47 deleted the fix/esp32-digital branch December 31, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaff slaff slaff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff