Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate LimitedMemoryStream buffer on demand and not upfront. #2153

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Allocate LimitedMemoryStream buffer on demand and not upfront. #2153

merged 2 commits into from
Nov 13, 2020

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Nov 13, 2020

No description provided.

@slaff slaff added this to the 4.2.0 milestone Nov 13, 2020
@slaff slaff requested a review from mikee47 November 13, 2020 12:55
@mikee47 mikee47 changed the title Allocate the requested memory on demand and not upfront. Allocate LimitedMemoryStream buffer on demand and not upfront. Nov 13, 2020
mikee47
mikee47 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@slaff slaff merged commit 0c80a59 into SmingHub:develop Nov 13, 2020
@slaff slaff removed the 0 - Backlog label Nov 13, 2020
@slaff slaff deleted the feature/lms-reserve-memory-on-first-write branch November 27, 2020 10:37
@slaff slaff mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 mikee47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @mikee47 @slav-at-attachix