Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_used_in_promo_rules instead of is_searchable for the image attribute. #826

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

afoucret
Copy link
Contributor

Fix #825

@afoucret
Copy link
Contributor Author

@romainruaud : can you test it please.

@romainruaud
Copy link
Collaborator

This one works as intended for me :

  • db schema properly updated
  • 'image' field still in mapping and indexed

This can be merged.

Just one point, on my dev environment, 'image' was (this is legacy, I can't remember why) "used_in_spellcheck=1".

This implies that an attribute can be "is_searchable=0" BUT "is_used_in_spellcheck=1" and would then have "copy_to : 'spelling'" in the mapping.

Maybe this should be also fixed in a separate issue ?

@afoucret
Copy link
Contributor Author

I fixed the is_used_in_spellcheck

@romainruaud
Copy link
Collaborator

Great for the "image" attribute, but I was thinking a more global fix, shouldn't we ?

Imho we should not be able to set an attribute to "is_searchable=0" and "is_used_in_spellcheck=1".

Your thoughts ?

@afoucret
Copy link
Contributor Author

Yep. Propose a patch for this.

@romainruaud
Copy link
Collaborator

Acknowledged, I will work on a separate PR for this one.

You can merge this one for now.

@afoucret afoucret merged commit d00b38c into Smile-SA:2.5.x Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants