Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't the tokenscript files be signed with *private* key #436

Open
wants to merge 744 commits into
base: main
Choose a base branch
from
Open

Shouldn't the tokenscript files be signed with *private* key #436

wants to merge 744 commits into from

Conversation

JustinFeng
Copy link

I believe the TokenScript file should be signed by the creator with their private key, the verified by public key

Please feel free to let me know if that's not how the TokenScript signature works, cheers

jzaki and others added 30 commits September 30, 2019 20:46
@jzaki
Merge pull request SmartTokenLabs#250 from AlphaWallet/require-enable…
2c6df68 
…d-DeFi

require the user enable DeFi services before making a supply/withdraw tx
Boon's contribution
13353c2
the makefile I wrote on Ubuntu 18.04 no longer works on Ubuntu 19.04.…
055783b 
… Fixed that.
@bitcoinwarrior1
add p tokens
3aebfa7
@bitcoinwarrior1
add dForce USDx
535889d
@zhangzhongnan928
Merge pull request SmartTokenLabs#251 from AlphaWallet/add-ptokens-an…
322df9d 
…d-dforce-usdx

Add ptokens and dforce usdx
@bitcoinwarrior1
delete contrib folder because we use resources instead
f230e7f
make every example only one directory deep
4e285e0
@bitcoinwarrior1
add multipliers and change schema to october
98d1c48
moving data out of tokenscript.xsd as it is becoming a project of its…
54b4e22 
… own.

adding bitmap to etherem element
revert the change of moving <data> definition to data
f9c2c97
@bitcoinwarrior1
moving data element definition to a module included from the main schema
32808e7
@bitcoinwarrior1
change all TokenScripts to match 2019/10
d98f902 
correctly reference tokenscript.xsd in schemaLocation
@bitcoinwarrior1
WIP add captcha to discovery token
4ecafdf
@bitcoinwarrior1
Merge pull request SmartTokenLabs#245 from AlphaWallet/october-schema
3e03544 
change schema to october
@bitcoinwarrior1
translate remaining DeFi tokens to 2019/10
c81466a
@bitcoinwarrior1
Remove dead link
1ca0325
the Venn picture explaining artefact and token will be referred to in…
f9f963a 
… a document at certain point
@bitcoinwarrior1
remove rounding on dai bridge
5b698af
@bitcoinwarrior1
Merge branch 'master' of https://github.com/AlphaWallet/TokenScript
94eb694
original data file was mostly about attribute process, hence the rena…
625afd3 
…me. Plus the new thing we discussed last week: data-objects
@hboon
Tweak text formatting
81a588c
@bitcoinwarrior1
fix wrong text on WETH unwrap layout
38295af
@bitcoinwarrior1
Allow users to gain tokens by email when service is down
71d5d97
@bitcoinwarrior1
add bonus for tweeting
a03cf1d
@bitcoinwarrior1
Merge pull request SmartTokenLabs#271 from AlphaWallet/unavailable-di…
843ba6b 
…scovery

Unavailable discovery
adding an explanation article articles/data-object.md to be shared be…
90fa55f 
…fore Thursday meeting and published after (with links to the result of discussion)
language improvement in the article
a36717e
copy-edited
50d89aa
introducing svg image as illustraction since we discoverred that pand…
aeb11cd 
…oc can work with svg (if rsvg-convert is installed). also fix some typo
oleggrib and others added 28 commits October 20, 2020 16:52
@oleggrib
updated token ID to use tokenID=... or ownerAddress=0x...
edf49d1
adding an 2nd example with activity defined
8c2bd3b
@oleggrib
added event parsing code with console output. to run code we have to …
8ed17c8 
…press button
@oleggrib
fix : let -> var
df5e09e
@oleggrib
added erc-20 activity cards pop-up
658a9dc
ready to be taken into master soon, renaming directories
1ab95b0
@oleggrib
changed message for connect/disconnect network and added button to Co…
135a5d9 
…nnect to Metamask
convert the error message to a table for better display
6a628bd
breaking things a bit by assuming passive negotiation and show the fi…
f640ed6 
…lter expression.
@oleggrib
added upload/download XML and filters
2e395bf
@oleggrib
fixed box title
491fe4e
@oleggrib
added tests, some code moved to separate module, active negotiation p…
2a5ec76 
…op-up removed
@oleggrib
every card use own iframe
6fb6c7c
@oleggrib
added live event update, new event marker, erc20 token props list and…
a70bc16 
… lot other improvements
relaxing contract name rule to allow NCName instead of ID, as contrac…
e7b2887 
…ts are referred by name, not by xml id
Merge branch 'master' of github.com:AlphaWallet/TokenScript
448410a
rolling back part of the change in SmartTokenLabs#388
d6e7dc1 
as we couldn't get the validator to work with the new <assert> statement
documented here
SmartTokenLabs#395
token name is required thanks to the previous merge of Oleg's token n…
e2a8c9a 
…egotiation
no longer using IDREF (replaced most with keyref) since many months a…
4855c96 
…go but found this left-over
allow contract reference & attribute refer to another
0ea2c00
allowing accessing storage
37c310e
docs are generated from the document repository
8054ba4
Set theme jekyll-theme-minimal
2076527
@nicktaras
Web example: devcon issuer
09ed5c0
@nicktaras
switched npm package polyfill for bigint to big-integer, updated Sign…
fce6c9b 
…edDevonTicket.jsto work with this polyfill library.
@AW-STJ
Merge pull request SmartTokenLabs#411 from TokenScript/web-examples
c81f55f 
switched npm package polyfill for bigint to big-integer, updated Sign…
adding flow chart for authenticator and negotiator
733aafd
@JustinFeng
Shouldn't the tokenscript files be signed with *private* key
39a561f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@JustinFeng @jzaki @bitcoinwarrior1 @zhangzhongnan928 @hboon @rosieprom @darakhbharat @oleggrib @nicktaras @AW-STJ