This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Get the full, descriptive error response returned from skyd #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Previously, methods were returning error messages that said e.g. "Request failed
with status code 429" and we had to drill down into the actual response to see
what the skyd error was.
All methods that make a request now return a descriptive error message based on
the skyd response message.
Added
ExecuteRequestError
which contains the original Axios error. We nowthrow this on network errors instead of
AxiosError
directly.Added
request.ts
file for ExecuteRequestError. I originally tried putting it inclient.ts
where it was causing circular dependencies and stuff not being definedat runtime.
Also, I fixed a bug where a promise in
uploadLargeFile
was not beingrejected on error.
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.