This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Added a revision number cache to make setJSON safer #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-tex
reviewed
May 31, 2021
kwypchlo
suggested changes
May 31, 2021
|
Is this PR still alive? Let's either close it or push it across the finish line. |
- Refactor SkyDB helpers to use revision cache and rename them - Make all SkyDB methods use revision cache - Make MySky DB methods call SkyDB methods or helpers - Update SkyDB tests
kwypchlo
suggested changes
Nov 8, 2021
|
We are probably going to change the spec, and I'm still adding tests. |
- [X] Integration test: setJSON and getJSON called simultaneously - [X] Unit test: setJSON and getJSON called simultaneously - [X] Integration test: setJSON and getJSON called with a delay - [X] Integration test: setJSON and getJSON called with two different clients (different local caches) - [X] Unit test: setJSON and getJSON called with two different clients (different local caches) - [X] Unit test: multiple setJSON calls where one fails
peterjan
previously approved these changes
Dec 13, 2021
ChrisSchinnerl
previously approved these changes
Dec 13, 2021
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.2 to 4.5.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.5.2...v4.5.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 37.1.0 to 37.2.0. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v37.1.0...v37.2.0) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Previously, methods were returning error messages that said e.g. "Request failed with status code 429" and we had to drill down into the actual response to see what the skyd error was. All methods that make a request now return a descriptive error message based on the skyd response message. - Added ExecuteRequestError which contains the original Axios error - Added request.ts file for ExecuteRequestError, where it was causing circular dependencies and stuff not being defined at runtime. - Also, I fixed a bug where a promise in `uploadLargeFile` was not being rejected on error.
Previously, the returned signature was longer than `SIGNATURE_LENGTH`. This is because `sign` returns the signed message (including the original message) which was not necessary -- we only need it to return the signature. In addition to being unnecessary, it was also confusing to have a signature that was longer than expected. We should have been using `sign.detached`. We already use `verify.detached`.
mrcnski
dismissed stale reviews from ChrisSchinnerl and peterjan
via
b840ef1
peterjan
reviewed
Dec 16, 2021
peterjan
approved these changes
Dec 17, 2021
ChrisSchinnerl
approved these changes
Dec 17, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec
https://hackmd.io/Sko_QDahR7SP2dQPmAmS-w