Fix bugs with Timespan#getAs

[sovdeeth]

Description

Remove rounding from getAs (it should truncate anyway) to avoid limiting as int max value. Fix bug where millis was multiplied instead of divided.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #6908

[TheLimeGlass]

Line 213 needs the Javadoc fixed aswell

-@deprecated Use {@link Timespan#Timespan(TimePeriod, long)}
+@deprecated Use {@link #Timespan(TimePeriod, long)}

[sovdeeth]

Line 213 needs the Javadoc fixed aswell

-@deprecated Use {@link Timespan#Timespan(TimePeriod, long)}
+@deprecated Use {@link #Timespan(TimePeriod, long)}

Is this an issue? Seems fine either way to me.

[TheLimeGlass]

Is this an issue? Seems fine either way to me.

There is no subclass called new Timespan.Timespan(TimePeriod, long)

[sovdeeth]

Is this an issue? Seems fine either way to me.

There is no subclass called new Timespan.Timespan(TimePeriod, long)

No, that's just the way to reference the constructor. It appear fine on javadocs:

[TheLimeGlass]

No, that's just the way to reference the constructor. It appear fine on javadocs:

VSCode using IntelliSense and Eclipse state otherwise

[sovdeeth]

No, that's just the way to reference the constructor. It appear fine on javadocs:

VSCode using IntelliSense and Eclipse state otherwise

Seems like an issue with those extensions, then, because it's valid in java docs specifications.

from https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#tag

[TheLimeGlass]

Seems like an issue with those extensions, then, because it's valid in java docs specifications. from https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#tag

Applying my suggestion solves the issue for IDE's and the Javadoc

[sovdeeth]

Seems like an issue with those extensions, then, because it's valid in java docs specifications. from https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#tag

Applying my suggestion solves the issue for IDE's and the Javadoc

I can make the change but you should probably report that as a bug and/or get a better extension/IDE, since it displays fine on intellij too