Add delete changer to ExprMessage #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
|
Are there already tests for this because I can't seem to find them? Also I am not fully sure how I would trigger an event like join to test this |
It'd need something like a JUnit where you manually call a message event |
|
Is 1 test for set and clear good enough or should I try to make a test for each event |
I think this is fine, but if you're willing, it can't hurt. |
sovdeeth
approved these changes
Jun 29, 2024
UnderscoreTud
approved these changes
Jun 30, 2024
Pikachu920
approved these changes
Jun 30, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the delete changer to message expression (so you can do stuff like
clear death message)Target Minecraft Versions: any
Requirements: none
Related Issues: #5919