-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds some fire resistant syntax #6639
Adds some fire resistant syntax #6639
Conversation
src/main/java/ch/njol/skript/conditions/CondIsFireResistant.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs tests
src/main/java/ch/njol/skript/conditions/CondIsFireResistant.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an expression to work along side others like %itemtype% named
or %itemtype% with damage
would be useful. Here's a mock design of one.
fire[ ]resistant %itemtypes%
give player fire resistant stone
%itemtypes% with fire[ ]resistance
give player stone with fire resistance
Adding format for in-verse effect would be useful too similar to how breakable player's tool
is being added
- Added an expression to create a copy of an itemtype with or without fire resistance - Added method checks to only register the syntax if the appropriate method exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Sovde's requests, LGTM.
These should all be added 👍
Added these too, but let me know if anything should change with them, first time writing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good from my view point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small little nit picks.
src/main/java/ch/njol/skript/conditions/CondIsFireResistant.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane Bee <shanebolenback@me.com>
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/conditions/CondIsFireResistant.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/conditions/CondIsFireResistant.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprWithFireResistance.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprWithFireResistance.sk
Outdated
Show resolved
Hide resolved
- Happy to add back a different version of this like what Fuse suggested, but general consensus seemed to be to get rid of it
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithFireResistance.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
re: test failures, it's |
Description
Adds the new fire resistant stuff to Skript.
Currently, stuff that is already fire resistant (e.g. netherite boots, etc) won't respect these methods (i.e. you can't make stuff thats already fire resistant not fire resistant). This is a flaw in 1.20.6 that was missed, and should be fixed in 1.21 whenever that comes around. For now, I'll leave them out of the tests and add a note in the expression description detailing that.
Target Minecraft Versions: Minecraft 1.20.5
Requirements: Spigot 1.20.5
Related Issues: none