Fix exception when no world available to explode effect. #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
added
bug
Moderocky
commented
Apr 19, 2024
| @@ -78,11 +78,13 @@ public void execute(final Event e) { | |||
| final Number power = force != null ? force.getSingle(e) : 0; | |||
| if (power == null) | |||
| return; | |||
| for (final Location l : locations.getArray(e)) { | |||
| for (Location location : locations.getArray(e)) { | |||
| if (location.getWorld() == null) | |||
There was a problem hiding this comment.
It's technically possible we could extract a location by checking whether only one world exists or looking for the default entity in the current event or whatever, but that feels like a really patchwork solution and in all other similar syntax we just skip it/return null when the world's null.
sovdeeth
approved these changes
Apr 19, 2024
APickledWalrus
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check for the location having a world in the create explosion effect.
If there is no world present then the effect will not occur (since we do not know where it should take place!)
Target Minecraft Versions: any
Requirements: none
Related Issues: closes #6481