Inventory Click event-value null check #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
approved these changes
Apr 17, 2024
|
Ah nuts I switched it to the wrong branch, give me a few minutes to fix the mess 😬 |
i was so confused when it suddenly switched to 23 commits |
Moderocky
force-pushed
the
fix-inventory-null
branch
from
d43a389
to
e11549a
Compare
|
Okay now I shall try to press the right button 🤣 |
sovdeeth
requested changes
Apr 17, 2024
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
id get arrested if i didnt Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
Apr 17, 2024
sovdeeth
added
bug
sovdeeth
added a commit
to sovdeeth/Skript
that referenced
this pull request
Apr 18, 2024
* null check * Update src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java id get arrested if i didnt Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> --------- Co-authored-by: Moderocky <admin@moderocky.com> Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
|
where can I download the latest skript.jar that contains this fix? |
|
checks tab -> java 17 -> artifacts -> download the zip |
|
sorry im not too familiar with github, could you send a link or further guidiance? apologies. |
|
checks tab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds a null check to the event-slot of the inventory click event
I tested it, it just returns air when clicking outside the inventory, which should be fine (probably)
Target Minecraft Versions: any
Requirements: none
Related Issues: #6458