ItemData/BlockCompat - strip out BlockState middleman #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
bug
sovdeeth
approved these changes
Mar 3, 2024
AyhamAl-Ali
approved these changes
Mar 5, 2024
AyhamAl-Ali
added
the
patch-ready
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Moderocky
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was originally meant to fix an issue with FallingBlocks loading chunk(0,0).
It turned into stripping out all references of BlockState in ItemType/ItemData/BlockCompat.It turned into deprecating all references of BlockState in ItemType/ItemData/BlockCompat and using BlockData instead.
These classes never cached nor actually ever used BlockState, it was merely a middle man to get to BlockData.
My guess is this was a pre-1.13 thing that just never properly got stripped out.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6471